I have tried many of the "fixes" to restore my photos after upgrade They are in iCloud I have run out of ideas

So all your pictures are safely in iCloud Photos, right? But your mac library seems confused? What I would do is this:

I would make a new Library (close Photos; option-click on the app; choose "Create New.") Then I would make the new, empty library the System Library (in Photos>Settings>General) and connect it to iCloud. And wait. Depending on the size of your Library, the new one should populate with all your pictures in a few days to, maybe, weeks if it's a really big library.

You didn't say-- is your library in your Pictures folder, or is it on an external drive? To get full functionality (and to avoid damaging the Photos Library) an external drive must be formatted in either APFS format or Mac OS Extended (Journaled) format. Additionally, the drive can not have had Time Machine on it since it was formatted.

Move your Photos library to save space on your Mac - Apple Support

Let us know....

Cool! Glad you got it to work!

If your photos are in iCloud (verify at iCloud.com/photos) simply enable syncing on your device (settings > photos)