Q: Should the iPod shuffle  be in the off position or on position when charging?  I have left it in the off position and it has been on for 12 hours and the green light never came on(still blinking amber).  Computer is on(never goes to sleep)

Hello lorenzod3046,

I would suggest turning the iPod shuffle to the off position when charging.  The blinking amber light means that the iPod shuffle is communicating with the computer, it does not mean that the device isn't charging.  Take a look at the information below:

iPod shuffle: Checking the battery charge - Apple Support
https://support.apple.com/en-us/HT204428​

    Blinking orange indicates that the unit is syncing with iTunes or that disk use was enabled in iTunes. In this state, iPod shuffle may be charging or fully charged. Check the charge status icon next to the iPod shuffle in iTunes or eject iPod shuffle from iTunes but leave it connected to USB and determine if the status light changes to solid green or solid orange.

Cheers,