Q: Just had email from Apple asking for my details and card details is this right

Hi there monaghan-n,

Welcome to Apple Support Communities. 

If I understand correctly, you want to know if the email that you received is legitimate and from Apple. The article linked below provides a lot of great information and tips that should help you determine the legitimacy of the potential phishing email. 

Identifying fraudulent "phishing" email - Apple Support

This article outlines the steps you should take if you receive a malicious email:

Identifying legitimate emails from the iTunes Store - Apple Support

Ciao.