I understand how frustrating it can be to manage your Apple ID, since it is used for just about everything you do with your Apple products. If your Apple ID doesn't work, nothing works.
Before we go any further, it might be best for you to contact Apple ID Support because fixing Apple ID problems might require that you verify personal information that you must never post on this site (or any other). Apple has ways of verifying your identity that only they know. So if you don't get anywhere or don't want to spend too much time given the limitations of this support site's back-and-forth question and answer nature, start here: http://appleid.apple.com.
Sign in with your Apple ID credentials, verify the information under Security and Devices, and verify all the information is correct.
If everything on those pages appears to be correct, I suggest you continue with this site: Apple ID - Official Apple Support. Scroll down to the bottom of the page, where you will find a button labeled "Get Support" beneath the heading "Help me with Apple ID". Click it. That will load a page with the heading "What’s happening with your Apple ID".
The choice most applicable to your concern is "Other Apple ID Topics" which will lead to more options. One of them will lead to contacting Apple directly, and speaking with someone who can help. Let them sort things out. Be patient with them, since your Apple ID is literally the key to your account security and they will need to positively establish your identity before fixing whatever is wrong.
If you want to continue troubleshooting on your own, please read on:
I don't understand the last sentence.
I asked that question only because I wanted to confirm that you did not create a new Apple ID, which would be as separate from the "old" one as yours is from mine. Provided you did not do that, you can simply "sign out" of all the services that requires an Apple ID including System Preferences > iCloud, and then "sign in" again with your updated email address and password.
Secondly I went to my account (with my new Apple Id ) and went to "edit"
Where did you do that? On your Apple ID Account Page (https://appleid.apple.com/) or somewhere else?