Indoor photos are very yellow

The yellowish tint is a side effect of the type of lighting inside. The iPhone camera does not have settings like a dedicated digital camera to compensate for different lighting types. You can edit the picture and adjust the lighting on your computer.

Sounds like you have a defective camera. I'd suggest a trip to the Genius Bar and get it checked.

Outdoors, I get great shots with the iPhone and inside, depending on the light source, I get good shots. A little adjusting with iPhoto and the indoor shots look as good as the outdoor ones.

Well I figured out what was wrong with my "pink" photos. My monitor just went bad! Everything is off-color on it and I'm unable to calibrate it. It seems the green is gone from it. It's an older LCD (but not THAT old) and I've known the lamp was getting dim but hadn't expected this. Photos look ok on my other monitor.

Hmmm, all my photos have a distinct pink/maroon tinge to them, including outdoor shots so I know it's not the light. I know cell phone cams aren't great but this one is worse than others I've had.