iPhone not charging anymore ?

If under warranty, go to an Apple store. If not under warranty, go to an Apple store anyway. The geniuses will tell you if your battery is good or bad. If out of warranty, they can replace your battery for I believe $79 or google third party repair shops will can replace the battery for less.

Do you have access to another USB dock connector cable to rule out a problem with the cable you are using?

If there is a hardware failure and it sounds like there is, you have several options.

If a problem with the battery only, Apple will replace the battery only.

http://www.apple.com/support/iphone/service/battery/

If a problem with the battery only, there are also some 3rd party repair services that will replace the battery only.

If a hardware problem other than the battery, Apple offers an out of warranty or not covered under the warranty "repair" price, which pays for an exchange at a discounted price off of what was the full retail sales price for the original iPhone. The cost is $199 plus tax and this price does not require signing a new contract with AT&T.

If a hardware problem other than the battery, there are some 3rd party repair service that should be able to replace whatever needs to be replaced for less than $199, but probably for not much less depending on what needs to be replaced. Apple's price pays for an exchange.

Or for $199 you can purchase a 3GS and for less, purchase a 3G, or wait to see what Apple announces on June 7th to being their annual World Wide Developers Conference, but this will require signing a new contract with AT&T.

Loyalty and when your bought it has nothing to do with it.

Your HP has a hardware failure. Depending on the hardware failure, you can replace the failed part only, or purchase a new computer. If you decide on the latter, HP isn't going to give you a discount on a new HP computer based on your "loyalty" or anything else.

Apple is providing you a discount for a replacement. The full retail sales price for the original iPhone was $600 I believe, which you have used for 3 years. If a problem with more than the battery, Apple will do an exchange for $199 plus applicable sales tax which doesn't require signing a new contract with AT&T and includes a 90 day warranty. If a problem with the battery only, you can have the battery replaced by Apple for $86 including shipping plus applicable sales tax. Or you can have whatever needs to be replaced by a 3rd party for somewhat less depending on what needs to be replaced.

I hate to waste money that kind of money just to repair an old phone.

Once again - Apple's $199 "repair" price pays for an EXCHANGE - for another original iPhone.