I want to buy a new phone and iam a long time android user right now iam using pixel 3xl and i want to buy new phone but what should i pick iphone xs max or just the regular version iphone 11

Apple doesn't sell iPhone Xs anymore. If you're buying a new phone, get the newest iPhone 11 or iPhone 11 Pro. Not that there's anything wrong with iPhone Xs, it's just that iPhone 11 is even better. Coming from a Pixel 3, you likely enjoy night mode photography. iPhone Xs doesn't have night mode, but both new iPhone 11's do.

And when you move over from Android, use this link to help you transition data from your Android to your iPhone: Move from Android to iPhone, iPad, or iPod touch - Apple Support