how to transfer all my photos from my iphone that is not working to my new iphone

If the old iPhone is not working, and if you you didn't create a recent backup of that device, you can't transfer anything.

If you don't have a backup, but you were syncing contacts, notes, photos, etc. to iCloud, you will be able to retrieve (resync) those info as soon as you access the same Apple ID on your new iPhone.

Or you can try, at you own risk, to find a 3rd party repairer that can recover your info from that broken iPhone.

Regards

Giulio