Should I upgrade from Mojave to Catalina

Probably not. There are problems, and Apple doesn't allow entry of bug reports. It does work though, and it's only irritating. Nothing at all like Windows, where they don't listen AND they allow bad guys to post your bank information to the dark web. :-)

I wouldn’t do it. Have a 2017 iMac 27” i7 and tried upgrading from Mojave. The Catalina update failed but acted like it had installed and wouldn’t boot up. Tried reverting back to Mojave and now my data is split onto two partitions (this is apparently how Catalina handles drives now). I can’t access the data now without copying it all onto an external drive and then deleting the new data drive. Real pain.

Honestly I do not recommend it. I have a lot of problems with OS Catalina

If you want all the new apps and features then yes.