Hello fellow users in misery.
I have spent a a lot of time on the phone with Apple Support.
From my initial call, my issue with syncing to a new iPad Pro was escalated at least 3 levels. A case number was assigned, and Trina, my contact at Apple Support, walke me through a bunch of tests to identify the issue sources.
Trina had me download some diagnostic utilities that pulled a series of log and error files after I had made multiple attempts at synchronising data. I was told that the issue has been escalated to both MacOS System Software engineering and to the Photos system engineers.
As I have mentioned in previous postings, I tried all the methods that I knew to rebuild Library files for Photos.
I exported all original files from the Photos Library (original Nikon .nef files, jpegs and png sourced from Pentax, Canon, iPhone 4s, iPhone 6s and other sources) This amounted to over 17,000 images and a folder that was 137.8 Gb. I then tossed that Library and started with a fresh version of Photos with no images and reimported the 17,000 images. This effectively reverted every single RAW file to the original, unedited, uncorrected, uncropped and in many many cases, unrotated images - a major hassle to find and rotate let alone re-crop and aother adjustments. (But of course that is one of the beauteous features of shooting RAW - complete reversion without loss..)
This did not correct the overall black images issues. Live images came across as black but it you opened one, it would initially be black but would actually play through the frames and stay on the index frame until you closed the window at which point it would go black again.
I have continued to experiment with various methods and I have found one method that seems to give the best possible sync to the iPad. I exported the entire Photos Library to a Folder simply called "pngs". I exported the images as PNG files. These files are considerably larger than the raw, img and jpeg originals. In my case, the originals when exported produced a folder with 18,580 items weighing in at about 512 Gb. (Most images were in the range of 20-30 Mb).
Here is the so-so good news... this folder of PNGs when synced to the iPad, almost every image was perfect. I did also export some sub folders that contained panoramas, Live photos, videos, long exposure and bursts. Where these images apeared as part of the bulk export as well as the subfolders, there were some issues.
As mentioned previously, converting every image as jpeg or png is not particularly desirable. Jpegs are too lossy and png files are larger than desirable.
In conclusion, I still have serious issues with the synchronization of images to the iPad.
To my mind, I suspect that the issue is related to something missing in the reading of the .nef files produced by different versions of raw produced by various camera models. The Nikon nef files that were produced from a model D3000 camera seem to be much more problematic than those produced by a new Nikon D3300.
Given that I don't seem to have any problems with images synched to my iPhone 6s running iOS 13.2.3 but the iPad running iPadOS 13.2.3 does have these issues and there doesn't seem to be any issues on my iMac (late 2013) running MacOS 10.15.1, there is a problems with how Photos/MacOS handle their interactions with iPadOS.
BTW. I have an AppleTV (4th gen) that accesses my Photos Library from my iMac for the screen saver. All random images from my iMac are fine (other than the many photos I still need to re-reotate.) ie: No black images at all.
I do hope you have all taken up the chance to speak with Apple Support over the phone!