After signing in with your wife's ID, have you allowed plenty of time for the photos to sync back. The photos sync is very, very slow. People have posted it took two weeks or more for all their photos to sync. Do you see any signs of syncing in the Photos app.
If they do not eventually sync back, try Settings/Your Name/iCloud and slide off syncing. Wait a few minutes and then slide syncing on. Allow time for syncing to occur.
Last resort - have you tried signing out of iCloud and then sign back in?
Photo Library - Get help with your iCloud
Photos - Get help with missing photos
Also check iCloud.com/Photos using a computer browser to see if the photos are there.
When you change back to your daughter's ID, there may be some data loss, but you can minimize it. If syncing photos with iCloud, ensure Optimization is turned off in Settings/Your Name/iCloud/Photos and/or in Photos/Preferences/iCloud. Then make sure full resolution photos are on the device/computer. When signing out of iCloud, if asked whether you want to retain data, choose yes. Messages conversations will be lost if they are addressed to the ID. See the article below for other places that the old ID should be removed. See Winston Churchill's response in the below discussion. Also set up Family Sharing to keep access to your apps/purchases.
How to transfer all files from one iCloud account to another
Apple ID email address or password - What to do after you change
Family Sharing
Family Sharing - Set up