If i change the Apple ID on my phone will my pictures be deleted?

They shouldn't be if you make a name change to your current Apple ID. Note the restrictions in the article.

Apple ID Name Change.        

 What to do after you change your Apple ID or password - Apple Support    I suggest doing this before you change your Apple ID or password.

If you want to use a different Apple ID, when changing to the new ID, there may be some data loss, but you can minimize it. If syncing photos with iCloud, ensure Optimization is turned off in Settings/Your Name/iCloud/Photos and/or in Photos/Preferences/iCloud. Then make sure full resolution photos are on the device/computer. When signing out of iCloud, if asked whether you want to retain data, choose yes. Messages conversations will be lost if they are addressed to the ID. See the article below for other places that the old ID should be removed. See Winston Churchill's response in the below discussion. Also set up Family Sharing to keep access to your apps/purchases. 

 How to switch Apple IDs on your iPhone or iPad.      

How to transfer all files from one iCloud account to another.       

What to do after you change your Apple ID or password - Apple Support.      

Family Sharing.         

Family Sharing - Set up.