Hello Tracybee21,
Thank you for reaching out in Apple Support Communities. I understand you'd like to know the best method to transfer photos from one iCloud account to another.
Accessing and viewing your most memorable moments across your Apple devices is important and I'll be happy to help.
My recommendation is to download the photos from iCloud to a computer, by following the steps outlined in this helpful article: Download iCloud photos and videos From there, you can sync the photos to your Apple device by following the section that says, "Sync your photos manually with iTunes" in this article: Keep your photos safely stored and up to date on all of your devices
If you use Finder on a Mac, you'll want to follow the steps outlined here: Sync photos between your Mac and iPhone or iPad Once that's done, you'll now have access to all of your photos.
Please let me know if you have any additional questions or concerns.
Kind regards.