how do i upload photos from my icloud account to my windows pc

If your photos are in iCloud via iCloud Photos, two ways -- see the following:

Use the internet browser on the computer and log into iCloud.com and download the photos from there. You can download up to 1,000 at a time. To select multiple photos, click on one then scroll and hold the shift key while clicking on the last one. Then click the download icon (cloud with down arrow) in the bar at the top.

or use iCloud for Windows. See instructions in Set up and use iCloud Photos on your Windows PC - Apple Support