Hello Nanavirginniaw,
It sounds as though you have two different Appel ID accounts, and now unable to view the photos, and other information that was purchased or synced using that Apple ID.
If you have two different Apple ID accounts, and are wanting the purchases and information associated to that account on your device, you would have to sign in to that Apple ID. If you want to use the original Apple ID you had previously, please follow the steps outlined in the following article to cancel your recent iCloud Storage upgrade to prevent any future charges associated to this account.
See or cancel your subscriptions
Once you've canceled the subscriptions to the new Apple ID, you can sign out of that account on the device. For iPhone's, iPad's, and iPod Touches you can sign out in Settings > [your name] > Sign Out.
Once signed out you'll be able to sign in to the older Apple ID. Once signed back in you'll have access to your previously purchased apps, subscriptions, and content. You'll also have access to the photos, notes, reminders, and contacts that you have synced to that Apple ID as well.
Have a great day!