I have an Apple ID with an old email account that has not been used fir several years

If it's asking for it, its because there is some content tied to it still, that requires it. Media purchases and app[s are forever tied to the Apple ID that obtained them and in the case of Apps require it to update always.

The Apple ID does not stop working even if the email address no longer exists.

If you remember your old password you can sign in.

If you don't then you will need to recover it, to access whatever is still tied to it or choose not to setup the new iPhone with content from the old one: link-> If you forgot your Apple ID password - Apple Support

As a rule of thumb, you should always keep Ione Apple ID updated and accessible and not create multiple Apple Ids as things like this can happen.

A request for another Apple ID password is often caused by updates to apps/purchases that were made when using the other ID. Those purchases are tied to the other ID and can't be transferred. One option is to delete the apps/purchases made by the other ID and download them using the new ID if desired. After deleting the apps, it may be necessary to restart the device/computer before you can download the apps again. If necessary, check your purchases history to see which apps/purchases weren’t made by the current ID. 

Purchase History Review.  *

Or you can try to set up Family Sharing  between the IDs to keep access to your purchases.

Family Sharing.         

Family Sharing - Set up.        

TKHay wrote:

Hi

thank you, not even sure what is tied to that old id as not needed to use it.

Regardless, you'll need to restore access to it to move forward since there is something still tied to it.