If I bring my old I pad into the apple shop do you still upgrade them

Your best bet is to make an appointment (*) and have your old iPad inspected at an Apple Store among this list:--> Apple – Location Selector. After checking it out, they'll give you all the available options.

Regards

Giulio

(*) You can do it:

• Online:--> Genius Bar Reservation and Apple Support Options - Apple;
• Contacting a local Apple Store or AASP among the list provided above;
• Using the "Apple Store" app, available and downloadable from AppStore.

Taking your iPad to an Apple Store will do no harm - however, the technicians will not be able to update your iPad beyond iOS 9.3.5 (WiFi Only models) or iOS 9.3.6 (WiFi & Cellular models). Apple ended update support for these models in September 2016; your iPad2 is obsolete.

Your iPad cannot be updated to iOS 10 or later major versions of iOS, as the internal hardware does not meet the minimum technical requirements for new versions of iOS/iPadOS. This limitation cannot be bypassed; iPad2 is a 32-bit architecture device, whilst all recent versions of iOS/iPadOS are designed for 64-bit hardware platforms.

You may need to consider that compatible Apps for your iPad are increasingly difficult to find - as third-party developers have dropped support for 32-bit devices and older versions of iOS. As older versions of Apps are removed from the Apple App Store, you’ll not be able to (re)download or install them - which may severely limit the usefulness and utility of your iPad. As such, if you want or need to access most current Apps, requiring more recent versions of iOS, you’ll need to consider replacement of your iPad with a newer or current model.

Of current models, even the entry-level iPad9 has specifications and capabilities that will massively outperform you current iPad - and is compatible with the vast majority of current Apps. Other models are more powerful still.

I hope this information provides helpful clarity as to the limitations of your iPad2.