whats the best way to transfer music from an ipod to an iphone?

Assuming you have neither iTunes Match nor Apple Music subscriptions, your music cannot be stored in the cloud.

In that case, house your music in iTunes on a PC or Music on a Mac and sync both devices using that platform.

Use the same Apple ID on both and sync them via iCloud.