unable to upgrade icloud storage

Did you make sure, that your payment info is still correct and complete?

Change, add, or remove Apple ID payment methods - Apple Support

Any error messages given?

Did you contact your credit card company or bank about that?

In the meantime you can also pay for your iCloud services by using Apple ID balance and iTunes gift cards.