hi my icloud is already full, why they keep on charging me?

If you have an iCloud+ storage subscription, you pay every month you are using the extra storage. It’s a subscription, not a purchase. You pay every month until you cancel the subscription. If you cancel, your storage goes back down to the free 5GB limit.