Hello Josnoopy,
You want to make sure that you are following these steps that are outlined here at Add a payment method to your Apple ID:
Learn how to edit the payment method that you use for subscriptions like iCloud+ and Apple Music, apps from the App Store, and other Apple media purchases.
If you change your address, the credit or debit card information that you use with your Apple ID might be automatically updated by your financial institution, and you don't need to take action. But if there's an issue, add a new card first, then remove the old card.
Update your payment method on your iPhone or iPad
1. Open the Settings app.
2. Tap your name.
3. Tap Payment & Shipping. You might be asked to sign in with your Apple ID.
4. Tap Add Payment Method, enter the new payment method, then tap Done.
5. Tap Edit.
6. Tap the red delete button next to the old payment method, then tap Delete.
Sometimes it can hep to add another card, then you can remove the card that is expired, and then add it back, updating the information.
Additional information that may assist can be found on that same page.
Have a good day.