how to upload all photos from Macbook Pro to icloud

See the following Apple Support article for information on setting up iCloud Photos: Set up and use iCloud Photos - Apple Support

iCloud Photos is a syncing service. Any photo you delete from a device where iCloud Photos is turned on will also be deleted from iCloud and from any other device connected to iCloud Photos. You can potentially reduce the storage space required on a device by turning on Optimize Storage. See the following Apple article for more information: Set up and use iCloud Photos - Apple Support

Apple does not currently offer cloud-only storage for photos. If that is what you want or need, you may want to explore 3rd party options such as Google Photos or Dropbox.