My iPhone won’t let me update payment when I have money on my card so it should be working. It won’t let me download any apps without having a card on file. I’ve change the card and it still said payment declined.

You can have a credit card / debit card on file and an Apple Account balance.

If you have set your Apple Account balance as your default payment method, your default payment method will be used first by Apple when you need to make a payment.

Some purchases might require you to have a credit card on file, even if you use your Apple Account balance to make the purchase.

See -> If your payment method is declined in the App Store or iTunes Store

If your payment method is declined in the App Store or iTunes Store - Apple Support

⤵️

How to complete your purchase if a payment failed or was declined

1. On your iPhone or iPad, open the Settings app.
2. Tap your name.
3. Tap Payment & Shipping.
4. Add a different payment method and remove the old one. 
5. Try to complete your purchase.

If you still can't make a purchase

• You might have an unpaid order. Learn how to pay an unpaid order.
• Contact your financial institution. 
  • You might need to ask your financial institution to allow international purchases on your debit or credit card.
  • If you want to know why a debit card, credit card, or other payment method was declined, speak with your financial institution. Apple doesn't have information about why the payment method was declined.
• In some countries and regions, your payment method might be declined because of changes to local law. Learn about billing and purchases in Europe or what to do if your card is declined in India.
• Still need help? Contact Apple Support.

See also the following Apple articles:

Payment methods you can use with your Apple ID

Payment methods you can use with your Apple ID – Apple Support (UK)

fyi: Not all credit & debit cards seem to work with App Store / iTunes Store, try a different one, or preferably a credit card. If your card is not accepted as a paymenf method, you need to contact your bank.

Add a payment method to your Apple ID

Add a payment method to your Apple ID – Apple Support (UK)

• If you want to change your card, you need to add first the new card, then remove the old card.
• or if you want to use your Apple Account balance, you need to set your Apple Account balance as your default payment.

If you update your payment method or add funds to your Apple Account balance, It would take about 1 to 3 business days in order to process.

If you're still unable to update your payment method, Contact Apple Support.