Hey Raynephillips,
It was great to check your Apple ID and iCloud settings to see if that was the issue. When checking the Contacts app on your Mac, do you see the contacts there? Let's also check the iCloud website to make sure the contacts appear there. This will help to know if the contacts are indeed syncing with iCloud as expected.
If you don't see the contacts in the Contacts app on your Mac and on the iCloud website, double-check which account is being used as the default account. On your iPhone you'll tap Settings > Contacts, then scroll down to Default Account to see what it's set to. Here's more information to help check: If your iCloud Contacts, Calendars, or Reminders won’t sync - Apple Support
Set iCloud Contacts, Calendars, or Reminders as your default
If your contacts, calendars, and reminders are in iCloud, then iCloud automatically updates your information. If your information is in a third-party account, like Google or Yahoo, you can change your default account to iCloud. Changing your default account to iCloud won't move your existing information from a third-party service to iCloud.
Contacts
To see which account your contacts are in:
In iOS 16 or later:
1. Open the Contacts app and tap Lists in the upper-left corner.
2. Select "All iCloud" to see your list of contacts in iCloud. If you don't see the contact you're looking for, it might be stored in a different account.
3. Tap Lists in the upper-left corner, then tap "All [account]" to check each individual account set up for Contacts.
4. If you have a copy of your contacts from a third-party service in vCard format version 3.0 or later, you can import the contacts into iCloud.
Let us know what you find!
Take care!