Why is this keep asking me to update payment every time I use phone when I already have

Click on the link and you can choose your country.

Contact Apple for support and service

Find a phone number for your country or region, or start a SignTime session.

• The United States and Canada
• Latin America and the Caribbean
• Europe and Türkiye
• Africa
• Asia-Pacific
• Middle East

Check again -> If you need to change or update your Apple ID payment method

If you need to change or update your Apple ID payment method - Apple Support

OK.

Get more help and assistant from Apple directly, see Contact Apple for support and service -> Contact Apple for support and service – Apple Support (UK)