Already have google iCloud do i need apple

This is a long and complicated topic.

It is really up to you. iCloud has smoother interface to Apple's general ecosystem. With Google you probably have to use special apps and deliberate transfers whereas with iCloud it does it all automatically. Also realize that iCloud is really more syncing storage. Items in iCloud are intended to be on a device as well as on Apple's servers. I suspect Google's storage is essentially like a hard drive in the cloud. It will offer off-device storage and may save you more drive space, but will require more management and organization on your part

Realize that you could use both, or even just the free 5GB you get with Apple (I can make do with that). If you have a lot of photos you could store those with Google to get them off your device completely. Turn off photo syncing with iCloud and just use Google for that. Leave iCloud to do things such as syncing contacts and items that don't use so much space.