i made a new apple id to have more disk space on my macbook air
A new Apple ID account doesn’t make changes to the disk size of your MacBook Air. Not sure what the thought is with that strategy.
Your photos can be in Mac and iCloud; and if so configured, the full resolution can be in iCloud only, with a lower res version on your devices. As the standard 5 GB is easily filled with various iCloud storing apps, a decent size photo library may need more iCloud space, and thus an iCloud+ plan (subscription). Upgrade to iCloud+ - Apple Support. None of this is helped by a secondary Apple ID.