I fixed it! Again, currently, I don't use icloud, everything came from an Itunes backup that had over 80k photos total. How I fixed it.
I reset Location Services as some write-ups have said it may not be working properly. The Photos app and Camera are using your phone’s location via GPS to tag photos or photos. To reset Location Services. On your device, go to Settings > General > Reset and tap Reset Location & Privacy. This will reset your location settings to the factory default.
After that I did a hard reset and I could see the photos start updating in the search crazy fast.
_________________________
One other small annoyance, I came from an Iphone XS with super old firmware, and now on a 15 pro with 17.4.
In text messages, say someone texted you today, and you went in and deleted the individual text from them, (this would move the conversation back down your list to say yesterday or the last time they texted you, and that message wouldn't show up at the top of your screen still) Now with ios 17.4, if you delete say all the texts someone sent you today, their message thread still says up at the same spot from the original time stamp that was sent to you. It doesn't know to put that message down in your list further after you delete the single messages. I don't know when that changed? or if it's a bug in the new ios.
Or say you send a new text today to someone that that haven't texted in a few days ago... If you delete your own message that you just sent them after you send it, it still has their message thread at the TOP of your phone, it doesn't push it back to a few days later where it should be.
