I forgot my on my.old phone broken ihone and want my pic from icloud

iCloud uses your Apple ID and password. If you only have one Apple ID, it would be the same ID and password as you used to log into this forum. If you have another and have forgotten the ID or password, see the following:

If you forgot your Apple ID - Apple Support

or

If you forgot your Apple ID password - Apple Support

Were you using iCloud Photos on the old phone? If so, you can connect the new phone to the same Apple ID, and turn on iCloud Photos, to get them onto it. You could also log into the iCloud Web interface https://www.icloud.com/ now to see what photos you have stored there.

If you were not using iCloud Photos on the old phone, were you making backups that included photos? (There is a setting that lets you exclude photos from backups – to "save space" at the risk of losing your photos forever.). I am not aware of any easy way to view photos in a backup short of restoring the whole backup to a phone, but at least there would be hope of recovering the photos once you did that.

If you weren't using iCloud Photos, or making backups that included photos, the prospects are more grim.

You're not going to be able to recover any photos from the smashed phone itself – unless a repair shop can fix the phone WITHOUT replacing the phone or its "motherboard", or resetting and wiping the phone. So your chances for getting your photos back basically rest with there being copies stored somewhere OTHER than on the dead phone.