Having read nearly all the messages in this thread, I have come to the conclusion that no-one has a definitive answer to the iPhone 4s's battery issue. And that, for now, includes Apple.
My own experience is this: my girlfriend and I both bought out first ever iPhones last weekend. 16gb, one white and one black, through T-Mobile in the UK.
Hers has shown to have a much better battery life than mine. Neither of us use iCloud, but I still have MobileMe, and sync my contacts. calendars and emails. She has no MobileMe. Despite me doing all the things suggested (turning off just about everything that makes this a smartphone), my battery life is still siginificantly lower than my girlfriends'. And they key thing here is, that she has almost everything turned ON.
So I'm wondering ,why the difference? Could it be the 'corrupted contacts' theory? She had no data to sync. So could that be a cause?
One other difference has been that I work from home, where the 3G connection is extremely inconsistent. In fact, 2G is pretty weak and results in the phone often displaying 'No Service' but then a minute later, showing a 2 or 3 bar, 3G connection. My girlfriend gets a strong 3G signal, all day, where she works. Could that inconsistency of 3G (or even 2G) connection mean the phone is not constantly trying to get a connection?
I don't know.
What I do know, is that two identical phones are behaving very differently. Who knows what's causing this? How about the colour of the phone! I'm joking, but unfortunately I'm not laughing about this.
Come on Apple, I think it's about time you spoke to your millions of customers.
Please?