A few more 4s battery observations:
My specs:
iPhone 4s 5.0.1 64gb telstra 3g Perth WA
Ipad ios 5.0.1
iMac upgraded to os X Lion last night
1. I have tried most of the suggested fixes to improve battery life with reasonable success. The last week or so have been getting 2 days between charges with 4-5 hour usage. I had disabled iCloud.
Last night I upgraded my iMac to iOs x Lion and swiched on iCloud. At the same time enabled iCloud in iPhone and iPad. I enabled transfer of data for iCal, address book but not email and backup off. Find my iPhone on.
The iPhone was fully discharged yesterday and I recharged to 100% using the power adapter. The phone was fully charges at about 10pm last night. All background apps were closed. Location services were switched off and cellular data was off.
At 0600 this morning the phone had discharged to 95% having done nothing all night.
The night before enabling iCloud and all other things the same the battery was still on 100% in the morning after being fully charged the night before.
I'm pretty sure iCloud is at least part of the problem.
2. I did a hard reboot this morning and noticed that the location services light went on, and stayed on, in task bar. The light stayed on for about 5 minutes and only went off after I went into settings and switched location services to off, then back on again. Light then stayed off.
I'm pretty sure location services is part of the problem too.
3. I haven't noticed the same degree of battery problems with the iPad, same iOS. I mostly use the iPad at home, on wifi. Not sure if going away from wifi and switching to 3g (which I do more with the phone) may also be part of the problem.
Just a few amateur observations which I hope may contribute to finding a solution.