Well since it appears as though Apple is monitoring this thread, although with 59 pages of replies, I can't guess they're really doing anything about it. But I'll add my $.02.
I'm on AT&T and just upgraded from a 4 to a 4S. The battery life on my 4 was STELLAR!! I'm a real estate agent and am using my phone all day long. Phone calls, looking up property on the web, I even use my iPhone to open the lockboxes to get me into homes. I could go all day with my iPhone 4 and maybe by the time I got home around 7PM it would be down to 20% or so. (Now I would occasionally charge it while driving, but the battery life was exceptional)
Now I have my iPhone 4S. I've done the "Let it die and recharge thing" to "Condition" the battery and that did not help at all. Last night it sat on the charger (a Sony clock radio) all night powered off. (Hold top button slide red slider). It was at 100% this morning when I got up. I took it to the gym and watched a workout video while on the treadmill for 36 minutes. Checked in on Foursquare while at the gym (stole the mayorship too!). Took a photo of the Sunrise over Mount Rainier on the way home and posted that to Facebook. Played about 10 minutes worth of Bejeweled Blitz during our sales meeting this morning and posted to Facebook a frew times. I also received 3 phone calls, answered one of them and talked for maybe 5 minutes on it. The phone has been powered on for about 6.5 Hours and is currently at about 17% on the battery.
It is now typical that I leave the phone on the charger in my office, in my car, at home becuase I can literally sit there and watch the battery drain before my eyes. The battery life on my phone now is HORRIBLE.
What is the fix? I also did the whole "Reset all Settings" thing today . . . but doesn't seem to have helped.
There you have it.