Applescripting insert image with excel

Hi,

scumsuca wrote:

Does anyone know what I am doing wrong here?

Because the contents of the variable newPic is not the correct reference to the picture, it's a bug.

Try this repeat

----------------------------------------

repeat

setvfxnamerowtovfxnamerow + 1

set {tTop, tLeft, cellxx} to {top, left position, value} ofcellvfxnamecolumnofrowvfxnamerowofactive sheet

if cellxx = "" then exit repeat

set image_file to (jpegdir & cellxx & ".jpg") as text

makenewpictureatthebeginningofactive sheetwith properties {file name:image_file, top:tTop, left position:tLeft, height:140, width:280}

endrepeat

----------------------------------------

I have not worked through your script in detail, but I think the problem is that the images are not being inserted into the cells as such. What's happening is that the image is being created at the beginning of the worksheet and then moved into a position where its top, and top left, are relative to a referenced cell. Note, therefore, that when you move the cells the pictures will NOT move with it.

This is how I would do what I think you are trying to do, but if I'm wide of the mark do come back!

set imageFolder to (choose folder) --choose a folder containing the image files

tell application "Finder"

set imageList to files of folderimageFolder--assumes only image files in the folder

end tell

tell application "Microsoft Excel"

set rowHeight to standard height of worksheet 1 of workbook 1 --gets the row height from the frontmost worksheet of the frontmost workbook

set rowStep to round (140 / rowHeight) roundingup--calculates how many rows are needed to fit a picture height of 140

set thisStep to 0 --initiates the counter used to determine the row for the top of the picture

set theLeft to left position of cell 1 of row 1 --this is the left position of column 1, row 1. Change column to move pictures in.

repeat with imageFile in imageList--gets images from the list created earlier

set theTop to (top of cell 1 of row (1 + thisStep)) --calculates row for top of picture (starting at top of column 1, row 1)

set newPic to makenewpictureat beginning of worksheet 1 of workbook 1 with properties {file name: (imageFile as text), height:140, width:280, top:theTop, left position:theLeft} --creates the picture, sets height and width, and top and left positions

set thisStep to thisStep + rowStep--increments the row counter

end repeat

end tell

Message was edited by: Bernard Harte

Are you saying that you want the row height to be the same as the pictures themselves (and for each row to contain a picture)? (My script will place the image over several rows.)

Do you need empty rows between those containing pictures?

Do you have rows of equal height throughout the worksheet or do they vary?

A little more detail about your goal might help to give a workable solution.

It does make things clearer. Thanks.

The picture is not being placed in a cell, but is just being aligned with the left and top of a cell reference that you give it.

I am mystified why your pictures are going out of step with the rows, but I neglected to ask you which version you are using - I am on 2011 (14.1.4) - although I can't see how that would be causing the problem.

I have made some changes to insert the images in consecutive rows in a column and then to modify the height of each of the rows that contain an image. (I've also put a variable in for height and width so that you can adjust in one place if you need to.

One more thought: if this still gives you the same error, try quitting Excel altogether and making a completely new spreadsheet to try it on.

set imageFolder to (choose folder)

tell application "Finder"

set imageList to files of folderimageFolder

end tell

tell application "Microsoft Excel"

set imageHeight to 140

set imageWidth to 280

set imageCount to count of imageList

set theRange to range ("A1:B" & imageCount as string) of worksheet 1 of workbook 1

set thisStep to 0

set theLeft to left position of cell 1 of row 1

repeat with imageFile in imageList

set theTop to (top of cell 1 of row (1 + thisStep))

set newPic to make new picture at beginning of worksheet 1 of workbook 1 with properties {file name: (imageFile as text), height:imageHeight, width:imageWidth, top:theTop, left position:theLeft}

set thisStep to thisStep + 1

end repeat

set row height of theRange to imageHeight

end tell

Here's another thought: there's a picture placement setting that will move the pictures with cells but not resize them. That's what I have as default, but yours might be different. I can't reproduce the problem of going out of step with the row.

set imageFolder to (choose folder)

tell application "Finder"

set imageList to files of folderimageFolder

end tell

tell application "Microsoft Excel"

set imageHeight to 140

set imageWidth to 280

set imageCount to count of imageList

set theRange to range ("A1:B" & imageCount as string) of worksheet 1 of workbook 1

set thisStep to 0

set theLeft to left position of cell 4 of row 1

repeat with imageFile in imageList

set theTop to (top of cell 4 of row (1 + thisStep))

set newPic to make new picture at beginning of worksheet 1 of workbook 1 with properties {file name: (imageFile as text), height:imageHeight, width:imageWidth, top:theTop, left position:theLeft, placement:placement move}

set thisStep to thisStep + 1

end repeat

set row height of theRange to imageHeight

end tell

I am glad it works. Frankly, if both the scripts work equally well I am at a loss as to what was happening previously.

I suspect you may have picked-up some corruption somewhere.

Hi Guys, thanks for the script, it works well.

The script sets the height and width of images in pixels, wich its not desireble when having many pictures of different sizes. In my case it's necessary to keep the aspect ratio of the images imported into excel.

Is there any way to set the size of the image in a percentage of the original instead of fixed pixels?

Thanks very much!

Francis

I suppose you could get the dimensions and then do the maths on it and then set the dimensions

To get the dimensions something like this would work

then manipulate the output and set it to your image

tell application "QuickTime Player 7"

set mydocument to document 1 -- gets frontmost open movie

set myproperties to properties of mydocument-- gets properties of movie as list

tell mydocument-- each of the following gets an individual property

set mydimensions to dimensions

end tell

end tell

mydimensions

then manipulate the output and set it to your image.