contacts not showing up in iCloud

Welcome to the Apple Community.

First check that all your settings are correct, that contact syncing is checked on all devices (system preferences > iCloud on a mac and settings > iCloud on a iPhone, iPad or iPod).

Make sure the contacts you are adding are added to your 'iCloud' group and not an 'On My Mac' or other non iCloud group (you can do this by checking in groups), non iCloud contacts will not sync.

If you are sure that everything is set up correctly and your contacts are in the iCloud group, you might try unchecking contact syncing in the iCloud settings, restarting your device and then re-enabling contact settings.

Some of your contacts on your phone are Gmail, etc. contacts (saved to Gmail instead of iCloud account). Your phone contact list is a combined list that includes contacts from several of your accounts i.e iCloud, Gmail, Yahoo, etc.

You have to Import your Contact list from each of your other accounts to your online iCloud account. To do this: Login to your Gmail account < Select “Gmail” on the upper left and change to “Contacts” from the drop-down menu < select “more” in the left pane < “EXPORT” < agree to go to “old version” if asked < select “more” that is above your contact names < select “All Contacts” and “vCard” format, a Save box comes up. Name the file and Select where you want to save it to on your computer (anywhere as long as you can remember where to find it).

Now go to your iCloud.com account on your computer < Contacts < select the settings spoke wheel on the bottom left of the left pane < select ‘Import vCard” < select the (Gmail) vCard file you saved on your computer in the last step.

Do the above import for each of your non-iCloud accounts, i.e. Import into iCloud your Gmail Contacts then Import your Yahoo contacts, etc. Don’t forget to Import each of your Gmail accounts if you have more than one Gmail account.