iCloud can't find my iPhone

I have an iPhone 4 and iCloud hasn't worked for me for my months. Every time I try to login it says that my iPhone is offline, even though it's on and I'm using it. I have Location services on under general settings but not sure if I need to change something else. If anyone has some ideas I would really appreciate it! It's so annoying when I'm trying to find my phone.