My friend just got a new iPhone how does she get the pics from iCloud and transfer to her new iphone

If they're in photo stream, set up the same iCloud account in Settings>iCloud, then turn photo stream to on. If they were in the camera roll, your friend needs to restore to her iCloud backup to recover them.

Hi

She should get her photos and music from iTunes. From the computer where they originated and where her back-ups should be.

An iCloud back-up of her phone will only back-up her camera roll to the Cloud servers and so if you restore to that back-up that's all she will have. It does not back-up any albums, Photostream or imported photos.

It would be best to document what the old phone and IOS is, the new phone and IOS and the computer and iTunes version.