Find my phone stopped working

Hello

I can locate my I phone 4 on Find My Phone at home but if i go out and try and locate it on another device it just says old location. This is a problem that has just happened a couple of weeks ago. I have tried switching location services on and off but nothing.

Worried if i lose my phone I will not be able to locate it. Can anyone shed any light on this please.