Apple Script to rename images using CSV file

Last try with rsync:

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

rsync -a "$OldImageName" "$NewImageName"

rm "$OldImageName"

done <"$2"

Ah! Good catch

Adding this line should get rid of the carriage return (if it's a UNIX \n return)

NewImageName=${NewImageName//\\n}

So try:

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

NewImageName=${NewImageName//\\n}

mv "$OldImageName" "$NewImageName"

done <"$2"

Looks like you're not selecting a CSV file.

If its a CSV file, you can open it with Textedit.

If the file is an Excel file, then in Excel, File->Save As... and in [Format] select Comma Separated Values (.csv);

This will fix the line endings per Mark's comment:

NewImageName=$( echo "$NewImageName" | tr -d '\r' )

So, try this:

cd "$1"

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

NewImageName=$( echo "$NewImageName" | tr -d '\r' )

if [ -e "$OldImageName" ] ; then

mv "$OldImageName" "$NewImageName"

else

echo "$OldImageName" >> ~/Desktop/Errors.txt

fi

done <"$2"

I like Mark's suggestion of testing with file:

cd "$1"

tFile=$(mktemp -t tmp)

fType=$(file -b "$2")

if [ "$fType" = "ASCII text, with CR line terminators" ]; then

cat "$2" | sed 'a\' | tr '\r' '\n' > "$tFile"

elif [ "$fType" = "ASCII text, with CRLF line terminators" ]; then

cat "$2" | sed 'a\' | tr -d '\r' > "$tFile"

else

echo "Problem with CSV file ($fType)" > ~/Desktop/Errors.txt

rm "$tFile"

exit 1

fi

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

if [ -e "$OldImageName" ] ; then

mv "$OldImageName" "$NewImageName"

else

echo "$OldImageName" >> ~/Desktop/Errors.txt

fi

done < "$tFile"

rm "$tFile"

Edit: Need to do no conversion if LF's:

cd "$1"

tFile=$(mktemp -t tmp)

fType=$(file -b "$2")

if [ "$fType" = "ASCII text, with CR line terminators" ]; then

cat "$2" | sed 'a\' | tr '\r' '\n' > "$tFile"

elif [ "$fType" = "ASCII text, with CRLF line terminators" ]; then

cat "$2" | sed 'a\' | tr -d '\r' > "$tFile"

elif [ "$fType" = "ASCII text" ]; then

cat "$2" | sed 'a\' > "$tFile"

else

echo "Problem with CSV file ($fType)" > ~/Desktop/Errors.txt

rm "$tFile"

exit 1

fi

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

if [ -e "$OldImageName" ] ; then

mv "$OldImageName" "$NewImageName"

else

echo "$OldImageName" >> ~/Desktop/Errors.txt

fi

done < "$tFile"

rm "$tFile"

That is strange. It works when I tested on the data in your file.

I wonder what you would get if you just tried to print the lines in the file.

Try this:

cd ~/Desktop

while read line

do

echo $line

done <"Untitled.csv"

jorrflv wrote:

Tony, You seem to be giving a lot of help here and I appreciate that. I am trying to do something similar with pdf files, but I am not getting errors, nor are my file names changing.

Do you see anything wrong with the code?

First lets see that the csv file has the correct line endings.

Create a test csv file with TextEdit in Plain Text (TextEdit->Format->Make Plain Text).

Type a few lines in by hand (don't cut-n-paste) and then run the workflow selecting this csv file.

(If it is a problem with the line endings, then we can add a line to the script to do a conversion)

If it still is not working, lets debug with "echo":

add: echo before cp and mv and then at the end of each line add: >> $HOME/Desktop/debug.txt

This will create a file on the Desktop showing us what is (or is not) happening

jorrflv wrote:

I tried new .csv file it was same results. I tried adding the echo command and I am not getting any debug files. Should look like this?

Need to add >> before $HOME (this redirects stdout to a file):

>> $HOME/Desktop/debug.txt

Also, it should not matter, but remove the white space in the script:

cd "$1"

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

echo cp "$OldImageName" "~/Documents/$NewImageName" >> $HOME/Desktop/debug.txt

echo mv "$OldImageName" "$NewImageName" >> $HOME/Desktop/debug.txt

done < "$2"

And post a few line of the csv file so that I can test it on my end

ok, so it looks like it's not finding the file (it looks like it's not changing to the directory with the file)

First, remove the debug (echo and >> $HOME/Desktop/debug.txt)

Now, lets try the command by hand in Terminal:

Open Terminal (Applications/Utilities/Terminal)

cd to the Folder with the files (enter cd and then the folder name and then press enter.)

You should see the folder name in the command prompt.

For example, when I cd to Documents, I see: MacBook-Air:~/Documents Tony$

(You can get a list of the directory by entering ls)

When you are sure you changed to the correct directory:

Copy the commands that's in the debug.txt file and paste into the Terminal Window:

cp Student1.pdf /Users/orrj/Documents/Aizenberg_Samuel_0028

and

mv Student1.pdf Aizenberg_Samuel_0028

If these copy and move as expected, then lets debug the cd command:

Add echo to the 1st line:

echo cd "$1" > $HOME/Desktop/debug.txt

(note: the single > will overwrite the existing debug.txt file)

jorrflv wrote:

added the line no go... here are the results of terminal command

OldImageName,NewImageName^MStudent1.pdf,Aizenberg_Samuel_0028^MStudent2.pdf,Alex ander_Pierce_0024^MStudent3.pdf,Anderson_Eric_8583^MStudent4.pdf,Apalategui_Aim e e_7987^MStudent5.pdf,Attanasio_Nia_7722^MStudent6.pdf,Ayoub-Butcher_Angelina_00 9 9^MStudent7.pdf,Badger_Gage_7751^M

Looks like just a CR (my guess was CRLF)

This should work (translates CR to LF to file.tmp then deletes the tmp file when done):

cd "$1"

tr '\r' '\n' < "$2" > ~/Desktop/file.tmp

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

cp "$OldImageName" "~/Documents/$NewImageName"

mv "$OldImageName" "$NewImageName

done < ~/Desktop/file.tmp

rm ~/Desktop/file.tmp

Check that there are no spaces in the files ext (i.e. "wav ")

Sorry, I didn't realize the headers were written directly into the CSV file. You'll want to skip the first line. Or maybe better, catch and ignore file-doesn't-exist errors like so:

tell application "System Events"

try

set name of file oldFileName of folder "path/to/folder of images" to newFileName

end try

end tell

Oh, if you want the files with _1 in the same folder, just delete ~/Documents/ and use:

cd "$1"

while read line

do

OldImageName=${line%,*}

NewImageName=${line#*,}

cp "$OldImageName" "$NewImageName"_1

mv "$OldImageName" "$NewImageName"

done <"$2"

“Ditch_Witch_SK_300.jpg%0D” has failed to upload due to an error

Sorry, this file type is not permitted for security reasons.

You have Window's line endings in your csv file. You need to replace the CRLF characters with the unix newline character.