Q: I need to get all photos off old iphone

Save any photo stream photos to the camera roll, then import the camera roll photos to your computer, as explained here so they are backed up: http://support.apple.com/kb/HT4083.

Then back up your old phone, either to iCloud (if it still has service) or to your computer using iTunes.  Then restore this backup to your new phone to transfer your camera roll photos, text messages, app data, settings, apps and other purchased media, etc.  More details here: http://support.apple.com/kb/ht2109.