I have edited my Apple ID. In doing this I have edited my email address , password and payment info on Apple ID however my iCloud will not allow me to change my sign in!! Any ideas how I do this as currently it is using my old login details

To change the iCloud ID on your devices you have to go to Settings>iCloud, tap Delete Account, provide the password for the old ID when prompted (if using iOS 7), then sign back in with your current ID.

If you don't know the password for your old ID, or if it isn't accepted, you will have to temporarily recreate it in order to delete the existing account. To do this, go to https://appleid.apple.com, click Manage my Apple ID and sign in with your current iCloud ID. Click edit next to the primary email account, change it back to your old email address and save the change. Then edit the name of the account to change it back to your old email address. You can now use your current password to turn off Find My iPhone on your device, even though it prompts you for the password for your old account ID. Then save any photo stream photos that you wish to keep to your camera roll. When finished go to Settings>iCloud, tap Delete Account and choose Delete from My iDevice when prompted (your iCloud data will still be in iCloud). Next, go back to https://appleid.apple.com and change your primary email address and iCloud ID name back to the way it was. Now you can go to Settings>iCloud and sign in with your current iCloud ID and password.