What is the difference between "iCloud note" and "on my mac note"?

Hi c michael mccoy,

The difference is that your "iCloud Notes" gets synchronized between all of your Apple devices as long as you are signed in with the same iCloud account, where your "My Mac Notes" are only locally stored on your Mac.

With kind regards,

David

Yep, as long as you have also stored the content of the note in iCloud notes.