our icloud is not working

Here are some suggestions for getting the best results from this site.

Create a user profile that accurately reflects the type of hardware you're using and your version of OS X, or include that information in your first message.

Give details of the problem. Don't just state your conclusion as to what's causing it or how it should be solved. A remark such as "X doesn't work" conveys no useful information. If X did work, you wouldn't be here. Instead, you should post something like this: "I did A; I expected B; but I got C." Include the complete, verbatim text of any error messages you saw, and specify where you saw them: in an application window, a CrashReporter window, a log, or whatever.

Also describe the steps you’ve taken yourself, if any, to try to resolve the issue. If the problem is of recent origin, did you make any changes to your setup just before you first noticed it? Is the problem reproducible or intermittent? That is, does it always manifest itself when you take a certain action, or only at unpredictable times?

Before posting, ask yourself whether it’s likely that you are the the only person ever to have had this problem. If not, search the discussions for answered questions similar to yours. If you found any pertinent information, but it didn't help, give details.