how do i get my pictures from my old broken phone to my new phone

Actually, you can recover photos from iCloud or iTunes backup using some software, like FonePaw iPhone Data Recovery or Dr.Fone which are popular data recovery. The advantages of these software is that you can recover files from backup selectively. It will be really convenient for iOS device users.

but ii cant figure out how to get all my old pictures...

Enable My Photo Stream on your new device as described here:

Get help using My Photo Stream - Apple Support https://support.apple.com/HT203511

Older photos may no longer be in iCloud. Which photos are you seeing in My Photo Stream? My Photo Stream is only storing the photos added during the last month in iCloud, and also at most 1000 photos. The photos you added longer ago will no longer be in iCloud. You cannot restore them from iCloud.

Have you tried to restore the new iPhone from a backup of your old iPhone 4? An iCloud backup or iTunes backup will include all photos that are in the camera roll, see: iOS: Back up and restore your iOS device with iCloud or iTunes

Do you have older backups on a computer with iTunes? Then you should be able to select the last backup of your old iPhone.

iTunes

1. Connect your device to the computer that you stored your backup on.
2. Open iTunes. If iTunes tells you there's an iOS update, get the latest version.
3. Go to File > Devices > Restore from Backup. If you're using Windows and don’t see a File menu, press the Alt key.
4. Look at the date and size of each backup and pick the most relevant.
5. Click restore and wait for the process to finish. Your device will restart and then sync with your computer. Stay connected until the sync finishes.