I just changed my hd and I did the same, cloned the old one to the new one and it did not work. Now I tried something and it worked.>
Go to mac settings > turn off icloud (delete icloud items from mac and sign out)
Go to your account and go on the main pictures folder you will find a Photos folder with nearly the same icon as the photos application and throw it in the trash
Go back on mac settings > turn on icloud again
Turn on every item you had so that it will be the same. open the photos application and it will automatically ask you to create a new library.
Go back to the settings and tick every box in the photos from the icloud.
Done
thats how i did it hope it works!