mac server link aggregation not working

Have you setup the LACP bonding in the switch? You'll need to login to the Ethernet Switch (normally through an web interface, reference your switch manual) and select the ports you want to bond together.

First off, what does the Network preferences dialog have to say about it? Usually it gives pretty good feedback as to the state of the links. Does it think they're up/functioning yet no traffic is passing? or does it report a problem.

Second, and orthogonal to the problem, is what you expect/hope to achieve via this anyway. If you have two devices on your network (e.g. one host and one NAS device) then you likely won't see any appreciable difference in throughput due to the way that LACP works - traffic to/from specific host pairs will always use the same link. LACP is only an advantage when you have multiple hosts in play, so that the individual streams can be divided between the links, but traffic between any two given hosts will always use the same link.

If you have more than one host trying to access the NAS device, then it may make some sense to add LACP to the NAS, to improve throughput to the array (although it's still likely to be throttled by the disk speed).

I have a similar problem with mine. I have a mac pro connected to a Netgear web managed switch, now on both links it says ok, but it remains red and I'm getting a self assigned IP. Not sure what the problem is here.