The error message indicates an incorrect block structure, some missing "end".
I modified my original script (including OT's changes) and put it into my Dropbox:
https://dl.dropboxusercontent.com/u/45503699/PhotosBatchChangeTitleToKeywordsAlb umReplace.scpt.zip
There is a new variable "replace_old_title". If this is set to "true", any old title will be completely overwritten by the list of keywords.
-- batch change the title of images to the keywords
(* How to use this script:
Open this script in Script Editor. Launch Photos.
The photos can be passed to the script in two ways:
1. Either select photos while viewing the "All Photos" album; this works better than Moments or smart albums
2. Or collect the Photos in a top level defined album with a fixed name.
If you want to select the photos without collecting them in an album, set the variable "ReadFromAlbum" to false
If you want to pass the photos in a toplevel album, set ReadFromAlbum to true and change the variable "theAlbumName" to the name of the album you are using.
By default the old title will be overwritten. If you want to append to the old title, set the variable replace_old_title to false.
When all all photo are selected or in the album and all parameters set, press the "Run" button in Scripteditor.
*)
set ReadFromAlbum to false
set replace_old_title to true-- change this to false, if you want to append to the previous title
-- set this to true, if you want to pass the photos in a toplevel album
set theAlbumName to "PhotoDropBox" -- change this to the name of the album you will use
set imageSel to {}
set saved_delimiter to AppleScript'stext item delimiters--save the delimiter
tell application "Photos"
activate
if (ReadFromAlbum) then -- the photos will be passed in a toplevel album named "PhotoDropBox"
try
if existscontainertheAlbumName then
set thePhotosBuffer to containertheAlbumName
set imageSel to every media item of thePhotosBuffer
else
error "Album " & theAlbumName & "does not exist"
end if
on error errTexttwonumbererrNumtwo
display dialog "Cannot open album: " & errNumtwo & return & errTexttwo
end try
else -- process the selected photos from the All Photos album
try
set imageSel to (get selection)
on error errTexttwonumbererrNumtwo
display dialog "Cannot get the selection: " & errNumtwo & return & errTexttwo
end try
end if
-- check, if the album or the selected photos do contain images
if imageSel is {} then
error "Please select some images."
else
repeat with im in imageSel
try
tell im
--set the text item delimiter
set AppleScript'stext item delimiters to {", "} --use a comma and space as the delimiter
-- retrieve the keywords
set kws to its keywords as string
if not (exists kws) then
set kws to ""
end if
if (replace_old_title) then
set thename to "" -- the old title will be overwritten
else
set thename to its name
if not (exists thename) then
set thename to ""
else --retrieve the old title
set thename to thename & ", "
end if
end if -- (replace_old_title)
set its name to thename & kws
end tell
on error errText number errNum
display dialog "Error: " & errNum & return & errText & "Trying again"
try
delay 2 -- wait and try again
tell im
set AppleScript'stext item delimiters to {", "} --use a comma and space as the delimiter
-- retrieve the keywords
set kws to its keywords as string
if not (exists kws) then
set kws to ""
end if
if (replace_old_title) then
set thename to "" -- the old title will be overwritten
else
set thename to its name
if not (exists thename) then
set thename to ""
else --retrieve the old title
set thename to thename & ", "
end if
end if
set its name to thename & kws
end tell
on error errTexttwonumbererrNumtwo
display dialog "Skipping image due to repeated error: " & errNumtwo & return & errTexttwo
end try
end try
end repeat
end if
end tell
-- display dialog "Done"
set AppleScript'stext item delimiters to saved_delimiter--restore the delimiter
return "Done"