How can two iphones with same Apple ID but different phone numbers share locations in Find Friends?

For me I decided to make for example-my iphone a contact by the email i used for my Apple account by going to the Facetime app and searching up my email and adding it as a contact on my ipad.Then i went to my ipad and searched up myself by my number adding it to my contacts reason being on how i have so many ways to find me on Facetime is from when i first signed up i allowed search by email/number

If you are the one using both of these iPhones, then Find my Friends is not suitable for sharing location. You should use the built-in Find my iPhone app for that.

If these iPhones are used by different people, they should not be using the same Apple ID at all. If this is the case, you can see How to Stop Sharing an Apple ID and then you can use Find my Friends, once you have separate IDs.

(Note that I may receive some form of compensation, financial or otherwise, from my recommendation or link, because some pages on the site contain small banner ads).