Q: applescript faster

AppleScript is pretty slow to begin with - just about any other scripting language (Ruby, Python, etc) will be faster, not to mention something compiled like C or Objective-C.

There is an AppleScript quirk that getting or setting items in a list is speeded up if the list variable is referenced rather than being used directly, so you might try that.  For example:

on doSomething(bigList)
  script _script -- temporary script object
    property _list : bigList -- with a property set to the passed list
  end script

  set numItems to (count bigList)
  repeat with n from 1 to numItems
    get item n of _script's _list -- reference the script object's property
  end repeat
end doSomething

You can place your script objects with their variables anywhere, but by refactoring your script to use handlers/subroutines, it will be easier to make performance adjustments to your code.

You have a pretty complex flow there, so it's hard to be specific since I'm not familiar with your app, or what you're trying to achieve, but there are some hints.

For example, for problem 1, rewrite the lines:

repeat ttt times --PROBLEM ONE

  set r_d to r_d + 1

  if item r_d of scany_col is (item a_c of item 2 of pixelValues2) then

to:

set foo to (item a_c of item 2 of pixelValues2)

repeat ttt times

  set r_d to r_d + 1

  if item r_d of scany_col is foo then

The point here is that in the original script, (item 1_c of item 2 of pixelValues2) will be evaluated in every iteration of the loop, even though it never changes. Evaluating the value once and storing it locally will speed up this loop. How much depends on the number of iterations, but since you called it out, I assume it has to have some potential.

The other problem is harder to diagnose since there's a lot more going on at this point. However, one place to start would be:

  repeat (count items of a) / (count items of item b of Diams) * 0.7 times

As before, it doesn't look like 'count items of item b of Diams'  ever changes in this loop (neither b nor Diams is set to any new value), so there is no need to re-evaluate this on every iteration. Create a variable that contains the value before the loop starts and use that instead.

I can't help but think there's more to this, but can't quite get my head around what you're trying to do here.

Hello

I'm not sure I understand it correctly but here's my revision of your script. I introduced some optimisations and also fixed logic based upon my understanding.

Briefly tested with small images less than 256 x 256 pixels under OS X 10.6.8.

* Circle definitions list (given in property circles) is rather redundant and can be optimised more by using offset ranges.

Good luck,

H

_main()
on _main()
    script o
        property |NL| : return -- newline character in output
        property pp : {} -- list of {x, y} points
        property cc : {} -- list of {r, g, b} colours
        property scany_col : {} -- list of some auto-selected distinct colours
        property scany_col1 : {} -- re-ordered scany_col (promoted partial list)
        property tt : {} -- work list for re-orrdering dialogue result
        property a2 : {} -- list of {{r, g, b}, {x, y}, {x, y}, ...} for every {r, g, b} in scany_col
        property a : {} -- work list for points pool
        property a_vr : {} -- work list for points pool (not yet allocated in circle)
        property b_c : {} -- work list for re-ordering dialogue
        property d : {} -- work list of g-code per colour
        property g : {} -- list of g-code
        (*
            circle = {diameter, list of iternal points offset from reference point (bottom left point)}
            circles = {circle, circle, ...}
            
            diameter = 3
                -@-
                @@@
                -@-
                
            diameter = 4
                -@@-
                @@@@
                @@@@
                -@@-
                
            diameter = 5
                -@@@-
                @@@@@
                @@@@@
                @@@@@
                -@@@-
                
            diameter = 6
                -@@@@@-
                @@@@@@@
                @@@@@@@
                @@@@@@@
                @@@@@@@
                -@@@@@-
                
            diameter = 7
                --@@@--
                -@@@@@-
                @@@@@@@
                @@@@@@@
                @@@@@@@
                -@@@@@-
                --@@@--
                
            diameter = 8
                --@@@@--
                -@@@@@@-
                @@@@@@@@
                @@@@@@@@
                @@@@@@@@
                -@@@@@@-
                --@@@@--
                
            diameter = 9
                ---@@@---
                -@@@@@@@-
                -@@@@@@@-
                @@@@@@@@@
                @@@@@@@@@
                @@@@@@@@@
                -@@@@@@@-
                -@@@@@@@-
                ---@@@---
                
            diameter = 10
                ---@@@@---
                --@@@@@@--
                -@@@@@@@@-
                @@@@@@@@@@
                @@@@@@@@@@
                @@@@@@@@@@
                @@@@@@@@@@
                -@@@@@@@@-
                --@@@@@@--
                ---@@@@---
        *)
        property circles : {¬
            {10, {3, 0}, {4, 0}, {5, 0}, {6, 0}, {2, 1}, {3, 1}, {4, 1}, {5, 1}, {6, 1}, {7, 1}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {5, 2}, {6, 2}, {7, 2}, {8, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {5, 3}, {6, 3}, {7, 3}, {8, 3}, {9, 3}, {0, 4}, {1, 4}, {2, 4}, {3, 4}, {4, 4}, {5, 4}, {6, 4}, {7, 4}, {8, 4}, {9, 4}, {0, 5}, {1, 5}, {2, 5}, {3, 5}, {4, 5}, {5, 5}, {6, 5}, {7, 5}, {8, 5}, {9, 5}, {0, 6}, {1, 6}, {2, 6}, {3, 6}, {4, 6}, {5, 6}, {6, 6}, {7, 6}, {8, 6}, {9, 6}, {1, 7}, {2, 7}, {3, 7}, {4, 7}, {5, 7}, {6, 7}, {7, 7}, {8, 7}, {2, 8}, {3, 8}, {4, 8}, {5, 8}, {6, 8}, {7, 8}, {3, 9}, {4, 9}, {5, 9}, {6, 9}}, ¬
            {9, {3, 0}, {4, 0}, {5, 0}, {1, 1}, {2, 1}, {3, 1}, {4, 1}, {5, 1}, {6, 1}, {7, 1}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {5, 2}, {6, 2}, {7, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {5, 3}, {6, 3}, {7, 3}, {8, 3}, {0, 4}, {1, 4}, {2, 4}, {3, 4}, {4, 4}, {5, 4}, {6, 4}, {7, 4}, {8, 4}, {0, 5}, {1, 5}, {2, 5}, {3, 5}, {4, 5}, {5, 5}, {6, 5}, {7, 5}, {8, 5}, {1, 6}, {2, 6}, {3, 6}, {4, 6}, {5, 6}, {6, 6}, {7, 6}, {1, 7}, {2, 7}, {3, 7}, {4, 7}, {5, 7}, {6, 7}, {7, 7}, {3, 8}, {4, 8}, {5, 8}}, ¬
            {8, {2, 0}, {3, 0}, {4, 0}, {5, 0}, {1, 1}, {2, 1}, {3, 1}, {4, 1}, {5, 1}, {6, 1}, {0, 2}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {5, 2}, {6, 2}, {7, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {5, 3}, {6, 3}, {7, 3}, {0, 4}, {1, 4}, {2, 4}, {3, 4}, {4, 4}, {5, 4}, {6, 4}, {7, 4}, {0, 5}, {1, 5}, {2, 5}, {3, 5}, {4, 5}, {5, 5}, {6, 5}, {7, 5}, {1, 6}, {2, 6}, {3, 6}, {4, 6}, {5, 6}, {6, 6}, {2, 7}, {3, 7}, {4, 7}, {5, 7}}, ¬
            {7, {2, 0}, {3, 0}, {4, 0}, {1, 1}, {2, 1}, {3, 1}, {4, 1}, {5, 1}, {0, 2}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {5, 2}, {6, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {5, 3}, {6, 3}, {0, 4}, {1, 4}, {2, 4}, {3, 4}, {4, 4}, {5, 4}, {6, 4}, {1, 5}, {2, 5}, {3, 5}, {4, 5}, {5, 5}, {2, 6}, {3, 6}, {4, 6}}, ¬
            {6, {1, 0}, {2, 0}, {3, 0}, {4, 0}, {0, 1}, {1, 1}, {2, 1}, {3, 1}, {4, 1}, {5, 1}, {0, 2}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {5, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {5, 3}, {0, 4}, {1, 4}, {2, 4}, {3, 4}, {4, 4}, {5, 4}, {1, 5}, {2, 5}, {3, 5}, {4, 5}}, ¬
            {5, {1, 0}, {2, 0}, {3, 0}, {0, 1}, {1, 1}, {2, 1}, {3, 1}, {4, 1}, {0, 2}, {1, 2}, {2, 2}, {3, 2}, {4, 2}, {0, 3}, {1, 3}, {2, 3}, {3, 3}, {4, 3}, {1, 4}, {2, 4}, {3, 4}}, ¬
            {4, {1, 0}, {2, 0}, {0, 1}, {1, 1}, {2, 1}, {3, 1}, {0, 2}, {1, 2}, {2, 2}, {3, 2}, {1, 3}, {2, 3}}, ¬
            {3, {1, 0}, {0, 1}, {1, 1}, {2, 1}, {1, 2}}}
        
        set f to choose file with prompt "Выбери файл для обработки в G-Код " (* Select the file for processing in the G-Code *)
        
        tell application "iMagine Photo"
            set p to import graphic f
            if component error of p ≠ 0 then
                close p
                display dialog "Not an image file that quicktime recognizes."
                error number -128 -- user cancel
            end if
            set {x, y, w, h} to natural bounds of p
            set doc to make new window document with properties {dimensions:{w, h}}
            set drawing destination of p to doc
            draw p
            close p
            -- The following section is to be replaced depending on the pixel value class
            set pix_am to (w * h)
            set pv to (get pixel values of doc with properties {pixel value class:pixels in rectangle, bounds rectangle:{x, y, w, h}})
            (*  pv = {pixel points:{{x, y}, ...}, pixel colors:{{r, g, b}, ...}} *)
            close doc
            set pp to pv's pixel points
            set cc to pv's pixel colors
        end tell
        --return pv
        
        set scany_col to {}
        repeat 94 times -- select some distinct colours (max 94)
            set a_col to some item of my cc --взял случайный пиксель (* I took a random pixel *)
            if my scany_col does not contain {a_col} then set my scany_col's end to a_col
        end repeat
        set scany_col_sz to count my scany_col -- number of selected distinct colours
        display dialog ("нашел цветов: " & scany_col_sz) --giving up after 1 -- (* found flowers *)
        
        --(*
        (* change order of colours in scany_col *)
        repeat
            set b_c to {}
            repeat with i from 1 to scany_col_sz
                set {_r, _g, _b} to my scany_col's item i
                (* the position of *)
                set my b_c's end to "(на позиции " & i & "   " & (_r div 256) & ", " & (_g div 256) & ", " & (_b div 256) & ")" & |NL|
            end repeat
            
            display dialog (b_c as text) buttons {"оставляю", "меняю очередность"} default button 1 --giving up after 3
            (* {"leave ", "change the order"} *)
            set btn to result's button returned
            if btn is "меняю очередность" then (* change the order *)
                set msg to "ввести номера камор по указанному цвету через запятую " & |NL| & b_c
                (* enter the number of cameras to the specified color, separated by commas *)
                set txt to text returned of (display dialog msg default answer "")
                
                set {TID, AppleScript's text item delimiters} to {AppleScript's text item delimiters, {","}}
                set tt to text items of txt
                set AppleScript's text item delimiters to TID
                
                -- put colour of specified ordinal numbers to the top
                (*
                    E.g.
                    Given 4,7,2 in dialogue result, items 4, 7, 2 are moved to top in this order
                    (Invalid index is ignored)
                *)
                set scany_col1 to {}
                repeat with i from 1 to count my tt
                    try
                        set j to my tt's item i as integer
                        set my scany_col1's end to my scany_col's item j
                        set my scany_col's item j to false -- promoted thus scratched
                    end try
                end repeat
                set scany_col to scany_col1 & my scany_col's lists -- append the rest
            else
                exit repeat -- done
            end if
        end repeat
        --*)
        
        set a2 to {}
        repeat with c in my scany_col
            set my a2's end to {c's contents}
        end repeat
        repeat with i from 1 to pix_am
            repeat with j from 1 to scany_col_sz
                if my scany_col's item j = my cc's item i then
                    set my a2's item j's end to my pp's item i
                    exit repeat
                end if
            end repeat
        end repeat
        -- a2 : list of {{r, g, b}, {x, y}, {x, y}, ...} for {r, g, b} in scany_col
        --return a2
        
        --set kist to "G01 Z0" & |NL| & "G01 Z70" & |NL| -- # NOT USED ANYWHEER IN SCRIPT
        
        set g to {}
        repeat with e in my a2 -- for each colour entry
            set a to e's contents -- {{r, g, b}, points pool}
            set {_r, _g, _b} to my a's item 1 -- {r, g, b} -- this colour
            set a to my a's rest -- this points pool
            
            set d to {}
            repeat with c in my circles -- for each circle definition = {diameter, list of internal points offset}
                set circle to c's contents -- this circle
                set kfc to circle's item 1 -- diameter of this circle
                set cnt to (count circle) - 1 -- number of internal points of this circle
                
                repeat (count my a) / cnt * 0.7 times
                    set a_some to my a's some item -- some point in this points pool
                    set x to a_some's item 1
                    set y to a_some's item 2
                    
                    set x_1 to (x + kfc / 2) as integer
                    set x_2 to x + kfc
                    set y_1 to (y + kfc / 2) as integer
                    set y_2 to y + kfc
                    
                    if a contains {{x_2, y_1}} and ¬
                        a contains {{x_1, y_2}} and ¬
                        a contains {{x_1, y}} and ¬
                        a contains {{x_1, y_1}} and ¬
                        a contains {{x, y_1}} then -- 4 boundary points and 1 centre point of this circle are in this points pool
                        
                        --set my d's end to " Диаметром " & kfc & "pix " & x & " ,Y " & y --тут надо сразу G код писать с формулой окружности - проверку надо откорректировать, порет косяки
                        (* then you must immediately write to the G code of the circumference formula - checks should be corrected, flogs shoals *)
                        
                        -- point (x, y) can be the origin of a cirle of diameter d
                        set my d's end to "# circle of diameter = " & kfc & ", origin = (" & x & ", " & y & ")" & |NL|
                        (*
# circle of diameter = d, origin = (x, y)
                        *)
                        set a_vr to {}
                        set k to 0
                        repeat with i from 1 to count my a
                            set a_i to my a's item i
                            set dx to (a_i's item 1) - x
                            set dy to (a_i's item 2) - y
                            if circle contains {{dx, dy}} then -- in this circle
                                set k to k + 1
                            else -- not in this circle
                                if a_i ≠ a_some then -- unless it is current (x, y), which is already explored
                                    set my a_vr's end to a_i
                                end if
                            end if
                            if k ≥ cnt then exit repeat
                        end repeat
                        set a to a_vr -- update points pool to points not chosen in this cicrle
                    end if
                end repeat
            end repeat
            
            if (count my d) > 0 then -- only if any circle is allocated for this colour entry
                -- set colour and stand by (?)
                set my d's beginning to "G21" & |NL| & ¬
                    "(" & "R" & (_r div 256) & " G" & (_g div 256) & " B" & (_b div 256) & ")" & |NL| & ¬
                    "Z70" & |NL| & ¬
                    "M00" & |NL|
                (*
G21
(R[0..255] G[0..255] B[0..255])
Z70
M00
                *)
                set my g's end to d
            end if
        end repeat
        
        tell application "TextEdit"
            tell (make new document)
                set its text to g as text --as "class utf8"
            end tell
        end tell
        display dialog ("G-KODE как файл лежит открыт в текстовом редакторе") --giving up after 1
        (* G-CODE as the file is opened in a text editor *)
        return scany_col
    end script
    tell o to run
end _main

Ah, the diagram for diameter = 6 should have been as follows:

            diameter = 6
                -@@@@-
                @@@@@@
                @@@@@@
                @@@@@@
                @@@@@@
                -@@@@-

This diagram is only for explanatory purpose and does not affect the code.

H