My experience has been that changes are synced very rapidly after any change -- i.e., seconds to minutes. The devices do not need to be simultaneously connected to wi-fi for changes that are synced via wi-fi.
However, the initial syncing after turning on iCloud Photo Library however can take a significant amount of time (e.g., days) if you have a large library.