How long does it take to transfer my pictures to my new iPhone
Why is it taking so long for my pictures to load to my iPhone
It depends on: Photos' quantity and, if you're restoring them from a iCloud backup, on your wifi network speed.
If you're having problems, read this:
If iCloud Backup couldn’t be completed or you can’t restore - Apple Support
Regards
Giulio